root: make calling Close on the root actually close everything
#58
Conversation
That way, we can close and *then* cancel the context once we're ready to clean everything up.
ghost
assigned 
|
|
||
| var repub *Republisher | ||
| if pf != nil { | ||
| repub = NewRepublisher(parent, pf, time.Millisecond*300, time.Second*3) | ||
| repub = NewRepublisher(ctx, pf, time.Millisecond*300, time.Second*3) |
There was a problem hiding this comment.
It is probably better to create and start the new republisher at the very end of this function. Otherwise, if an error occurs, the republisher remains running unless the caller cancels the context. Although it may not matter since failure to create mfs root is probably fatal.
|
This repository is no longer maintained and has been copied over to Boxo. In an effort to avoid noise and crippling in the Boxo repo from the weight of issues of the past, we are closing most issues and PRs in this repo. Please feel free to open a new issue in Boxo (and reference this issue) if resolving this issue is still critical for unblocking or improving your usecase. You can learn more in the FAQs for the Boxo repo copying/consolidation effort. |
That way, we can close and then cancel the context as a final teardown. Really, we should consider not passing a context in the first place but it is useful for requests (where we just want to abort).